Add debug mode, fix validation of connection_state field of routeros_…

…firewall_filter resource, add missing hw_offload field to routeros_firewall_filter resource

main.go

@@ -1,6 +1,8 @@
 package main
 
 import (
+	"context"
+	"flag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/plugin"
 	"github.com/vaerh/terraform-provider-routeros/routeros"
 )
@@ -9,6 +11,18 @@ import (
 //go:generate go run github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs
 
 func main() {
-	plugin.Serve(&plugin.ServeOpts{
-		ProviderFunc: routeros.NewProvider})
+	var debug bool
+
+	flag.BoolVar(&debug, "debug", false, "set to true to run the provider with support for debuggers like delve")
+	flag.Parse()
+
+	opts := &plugin.ServeOpts{
+		ProviderFunc: routeros.NewProvider,
+	}
+
+	if debug {
+		plugin.Debug(context.Background(), "vaerh/routeros", opts)
+	} else {
+		plugin.Serve(opts)
+	}
 }

routeros/resource_ip_firewall_filter.go

@@ -77,9 +77,10 @@ func ResourceIPFirewallFilter() *schema.Resource {
 			Type:        schema.TypeString,
 			Optional:    true,
 			Description: "Interprets the connection tracking analysis data for a particular packet.",
-			ValidateFunc: validation.StringInSlice([]string{
-				"estabilished", "invalid", "new", "related", "untracked",
-			}, false),
+			ValidateFunc: validation.StringMatch(regexp.MustCompile(
+				"^((established|invalid|new|related|untracked),?)+$"),
+				"Value must be any of established, invalid, new, related, untracked, or a comma-separated "+
+					"list of those"),
 		},
 		"connection_type": {
 			Type:     schema.TypeString,
@@ -141,6 +142,11 @@ func ResourceIPFirewallFilter() *schema.Resource {
 			Description:  "Matches packets received from HotSpot clients against various HotSpot matchers.",
 			ValidateFunc: validation.StringInSlice([]string{"auth", "from-client", "http", "local-dst", "to-client"}, false),
 		},
+		"hw_offload": {
+			Type:        schema.TypeBool,
+			Computed:    true,
+			Description: "Whether or not rule is hardware offloaded",
+		},
 		"icmp_options": {
 			Type:        schema.TypeString,
 			Optional:    true,