-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more fine tuned controls for different devices #12
base: master
Are you sure you want to change the base?
Conversation
More sizes added. Example file also updated to integrate with the new additions
There are some breaking changes here so I'll move some of the code over and refactor and tag this PR in it. |
Okay. So what do I do now? Close the PR? (Sorry but i'm new to contributing.) |
@razein97 I keep it open to remind myself I still have to do it. Basically the solution I have in mind should keep the current setup in terms of being able to supply mobile, tablet and desktop at a high level. Similarly to the additional OrientationLayoutBuilder which you can then use to provide your orientation layouts I'm imagining an additional widget builder like This should allow you to get much more control as well if you look at it like this. ScreenTypeLayout.builder(
mobile: (context) => RefinedLayoutBuilder(
small: HomeMobileSmall(),
normal: HomeMobileNormal(),
large: HomeMobileLarge(),
extraLarge: HomeMobileExtraLarge()
) This will make it so that you can use the getValueForScreenType<double>(
context: context,
mobile: getValueForRefinedSize<double>(
context: context,
small: 10,
normal: 15,
large: 30,
),
); Hopefully I can get to it today. I'm not making a video this week so I'll be finishing up some things that's been lingering. |
Any update on this? |
@TutOsirisOm Not at the moment. My comment above described the implementation i will make if I have time, OP or you can implement that and make a PR? |
@FilledStacks I'll see what I can do! |
@FilledStacks How's this look? #19 |
More sizes added. Example file also updated to integrate with the new additions. Readme.md not edited.