Merge pull request #3 from ftlabs/localdata

tidied promise chain for handling local crossword data
Financial-Times · Jan 10, 2017 · 9c71851 · 9c71851
2 parents 367c93a + a866779
commit 9c71851
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/js/oCrossword.js b/src/js/oCrossword.js
@@ -132,11 +132,9 @@ function OCrossword(rootEl) {
 				.then(json => buildGrid(rootEl, json))
 				.then(()   => this.assemble());
 			} else { // assume this is json text
-				return new Promise(() => {
-					let json = JSON.parse(this.rootEl.dataset.oCrosswordData);
-					buildGrid(rootEl, json);
-				})
-				.then(()   => this.assemble());
+				return new Promise((resolve) => resolve( JSON.parse(this.rootEl.dataset.oCrosswordData) ) )
+				.then(json => buildGrid(rootEl, json))
+				.then(()   => this.assemble() );
 			}
 		} else {
 			this.assemble();