Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

Commit

Permalink
Passes verify, fixed placeholder test and added missing config defaul…
Browse files Browse the repository at this point in the history
…ts to readme
  • Loading branch information
Alberto Elias committed Jul 5, 2016
1 parent c3d0aa9 commit 127a530
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ In JS

Where `opts` is an optional object with properties

* `id` Source's ID of the video
* `source` Source of the video (currently only accepts `brightcove`)
* `id` [`Number`] Source's ID of the video
* `source` [`String`] Source of the video (currently only accepts `brightcove`)
* `optimumwidth` [`Number`] The optimum width of the video, used when there are multiple video renditions available to
decide which to display (the smallest one that's at least as large as this width, if it exists)
* `placeholder` [`Boolean`] Show just the poster image, load (and play) video on click
Expand Down
2 changes: 1 addition & 1 deletion demos/src/demo.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* global console */
import Video from './../../main.js';
import './../../main.js';

document.addEventListener("DOMContentLoaded", function() {
document.dispatchEvent(new CustomEvent('o.DOMContentLoaded'));
Expand Down
2 changes: 1 addition & 1 deletion test/ads.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global describe, xit, beforeEach, afterEach, expect, google */
/* global describe, it, beforeEach, afterEach, google */
const Ads = require('./../src/ads');
const sinon = require('sinon/pkg/sinon');

Expand Down
8 changes: 4 additions & 4 deletions test/video.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global describe, xit, beforeEach, afterEach, expect, google */
/* global describe, it, beforeEach, afterEach, before, after, should */
const Video = require('./../src/video');
const brightcoveResponse = require('./fixtures/brightcove.json');
const sinon = require('sinon/pkg/sinon');
Expand Down Expand Up @@ -73,7 +73,7 @@ describe('Video', () => {
it('should create Video objects only once', () => {
const videos = Video.init();
videos.length.should.eql(1);
const videos2 = new Video.init();
const videos2 = Video.init();
videos2.length.should.eql(0);
});
});
Expand Down Expand Up @@ -179,9 +179,9 @@ describe('Video', () => {
});

it('should be able to suppress placeholder play button', () => {
const video = new Video(containerEl, { placeholder: true, playButton: false });
new Video(containerEl, { placeholder: true, playButton: false });

expect(containerEl.querySelector('.o-video__play-button')).to.be.null;
should.equal(containerEl.querySelector('.o-video__play-button'), null);
});
});

Expand Down

0 comments on commit 127a530

Please sign in to comment.