Merge pull request #48 from Financial-Times/matth/fix-ended

Fix autoplay option adding ended listener when it shouldn't

src/js/playlist.js

@@ -6,12 +6,14 @@ class Playlist {
 		const currentId = opts.player.videoData ? opts.player.videoData.id : opts.player.opts.id;
 		this.currentIndex = currentId ? opts.queue.indexOf(currentId.toString()) : -1;
 
-		this.opts.player.containerEl.addEventListener('ended', this.next.bind(this), true);
-
 		this.cache = {};
 
-		if (this.opts.autoplay && this.currentIndex === -1) {
-			this.next();
+		if (this.opts.autoplay) {
+			this.opts.player.containerEl.addEventListener('ended', this.next.bind(this), true);
+
+			if ( this.currentIndex === -1) {
+				this.next();
+			}
 		}
 	}
 

src/scss/_info.scss

@@ -58,7 +58,7 @@
 		font-weight: 600;
 
 		&:empty {
-			display: none;
+			display: none !important;
 		}
 	}
 

test/playlist.test.js

@@ -46,17 +46,27 @@ describe('Playlist', () => {
 			sinon.assert.calledOnce(player.update);
 		});
 
-		it('listens for the video to end to trigger the next in the queue', () => {
+		it('listens for the video to end to trigger the next in the queue when autoplay is set', () => {
 			player.videoData = { id: 'bar' };
 
-			new Subject({ player, queue });
+			new Subject({ player, queue, autoplay: true });
 
 			// no DOM so trigger this on the listener directly
 			player.containerEl.dispatchEvent(new CustomEvent('ended', { bubbles: false }));
 
 			sinon.assert.calledOnce(player.update);
 			sinon.assert.calledWith(player.update, sinon.match({ id: 'baz' }));
 		});
+
+		it('doesn\'t listen for the video to end when autoplay is not set', () => {
+			player.videoData = { id: 'bar' };
+
+			new Subject({ player, queue, autoplay: false });
+
+			player.containerEl.dispatchEvent(new CustomEvent('ended', { bubbles: false }));
+
+			sinon.assert.notCalled(player.update);
+		});
 	});
 
 	describe('#next', () => {