Skip to content

Commit

Permalink
sessionId no longer used
Browse files Browse the repository at this point in the history
  • Loading branch information
apaleslimghost committed Nov 6, 2018
1 parent 8201cc3 commit 3d5ff99
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
15 changes: 7 additions & 8 deletions components/x-gift-article/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ npm install --save @financial-times/x-gift-article

## Styling

To get correct styling, Your app should have origami components below.
[o-fonts](https://registry.origami.ft.com/components/o-fonts)
[o-buttons](https://registry.origami.ft.com/components/o-buttons)
[o-forms](https://registry.origami.ft.com/components/o-forms)
[o-loading](https://registry.origami.ft.com/components/o-loading)
[o-share](https://registry.origami.ft.com/components/o-share)
To get correct styling, Your app should have origami components below.
[o-fonts](https://registry.origami.ft.com/components/o-fonts)
[o-buttons](https://registry.origami.ft.com/components/o-buttons)
[o-forms](https://registry.origami.ft.com/components/o-forms)
[o-loading](https://registry.origami.ft.com/components/o-loading)
[o-share](https://registry.origami.ft.com/components/o-share)
[o-message](https://registry.origami.ft.com/components/o-message)

## Usage
Expand All @@ -36,7 +36,7 @@ const b = <GiftArticle {...props} />;
const c = React.createElement(GiftArticle, props);
```

Your app should dispatch a custom event (`xDash.giftArticle.activate`) to activate the gift article form when your app actually displays the form.
Your app should dispatch a custom event (`xDash.giftArticle.activate`) to activate the gift article form when your app actually displays the form.
`document.body.dispatchEvent(new CustomEvent('xDash.giftArticle.activate'));`

All `x-` components are designed to be compatible with a variety of runtimes, not just React. Check out the [`x-engine`][engine] documentation for a list of recommended libraries and frameworks.
Expand All @@ -52,7 +52,6 @@ Property | Type | Required | Note
`articleUrl` | String | yes | Canonical URL
`articleTitle` | String | yes |
`articleId` | String | yes | Content UUID
`sessionId` | String | yes | This is needed to get a gift url.
`showMobileShareLinks` | Boolean | no |
`nativeShare` | Boolean | no | This is a property for App to display Native Sharing.
`apiProtocol` | String | no | The protocol to use when making requests to the gift article and URL shortening services. Ignored if `apiDomain` is not set.
Expand Down
1 change: 0 additions & 1 deletion components/x-gift-article/stories/native-share.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ exports.data = {
articleUrl,
articleTitle: 'Title Title Title Title',
articleId,
sessionId: 'session id',
nativeShare: true,
id: 'base-gift-article-static-id'
};
Expand Down
1 change: 0 additions & 1 deletion components/x-gift-article/stories/with-gift-credits.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ exports.data = {
articleUrl,
articleTitle: 'Title Title Title Title',
articleId,
sessionId: 'session id',
showMobileShareLinks: true,
id: 'base-gift-article-static-id'
};
Expand Down

0 comments on commit 3d5ff99

Please sign in to comment.