Merge pull request #680 from Financial-Times/fix-null-byline-case

fix: handle live blog posts without a byline
Financial-Times · Nov 9, 2022 · 71f6774 · 71f6774
2 parents 6249431 + 6d5a03e
commit 71f6774
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/components/x-live-blog-post/src/LiveBlogPost.jsx b/components/x-live-blog-post/src/LiveBlogPost.jsx
@@ -70,7 +70,7 @@ const LiveBlogPost = ({
 			/>
 		)
 	}
-	if (typeof byline === 'object' && 'tree' in byline) {
+	if (byline && typeof byline === 'object' && 'tree' in byline) {
 		postByline = (
 			<p className="x-live-blog-post__byline">
 				<RichText structuredContent={byline} />

diff --git a/components/x-live-blog-post/src/__tests__/LiveBlogPost.test.jsx b/components/x-live-blog-post/src/__tests__/LiveBlogPost.test.jsx
@@ -252,6 +252,13 @@ describe('x-live-blog-post', () => {
 			expect(liveBlogPost.html()).toContain('class="x-live-blog-post__body')
 			expect(liveBlogPost.html()).toContain('<p>structured live blog body</p>')
 		})
+
+		it('handles posts without bylines', () => {
+			const postWithoutByline = { ...regularPostContentPipeline, byline: null }
+			const liveBlogPost = mount(<LiveBlogPost {...postWithoutByline} />)
+			expect(liveBlogPost.html()).toContain('class="x-live-blog-post__body')
+			expect(liveBlogPost.html()).toContain('<p>structured live blog body</p>')
+		})
 	})
 
 	it('adds a data-x-component attribute', () => {