Skip to content

Commit

Permalink
Merge pull request #735 from Financial-Times/gift-article-tracking
Browse files Browse the repository at this point in the history
Gift Article Tracking changes
  • Loading branch information
jamesr101 authored Aug 16, 2023
2 parents 1cd8f8e + 13b36f0 commit 9377051
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions components/x-gift-article/src/CreateLinkButton.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const CreateLinkButton = ({ shareType, actions, enterpriseEnabled }) => {
className={`o-buttons o-buttons--big o-buttons--primary share-article-dialog__create-link-button ${
enterpriseEnabled ? 'o-buttons--professional' : ''
}`}
data-trackable={shareType + 'Link'}
onClick={createLinkHandler}
>
Create link
Expand Down
8 changes: 7 additions & 1 deletion components/x-gift-article/src/ShareArticleDialog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ import { AdvancedSharingBanner } from './AdvancedSharingBanner'

export default (props) => {
return (
<div className="o-typography-wrapper share-article-dialog__wrapper" hidden={props.isLoading}>
<div
className="o-typography-wrapper share-article-dialog__wrapper"
hidden={props.isLoading}
data-trackable={`share-modal | ${
props.enterpriseEnabled && !props.enterpriseRequestAccess ? 'b2b' : 'b2c'
}`}
>
<div className="o-overlay__close" />
<AdvancedSharingBanner {...props} />
<main className="share-article-dialog__main">
Expand Down
1 change: 1 addition & 0 deletions components/x-gift-article/src/SocialShareButtons.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const SocialShareButtons = ({
href={mailtoUrl}
rel="noopener noreferrer"
onClick={onClickHandler}
data-trackable="email"
>
<div className="o-share__icon__image">
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1024 1024">
Expand Down
2 changes: 1 addition & 1 deletion components/x-gift-article/src/UrlSection.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const UrlSection = (props) => {
<div
className="o-forms-input o-forms-input--text o-forms-input--suffix js-gift-article__url-section"
data-section-id={shareType + 'Link'}
data-trackable={shareType + 'Link'}
data-trackable="copy-link"
>
<input id="share-link" type="text" name={urlType} value={url} readOnly />
<button
Expand Down

0 comments on commit 9377051

Please sign in to comment.