Only display error message when response has failed

Financial-Times · Nov 29, 2018 · a54e574 · a54e574
1 parent 1765c0f
commit a54e574
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/components/x-gift-article/src/GiftArticle.jsx b/components/x-gift-article/src/GiftArticle.jsx
@@ -114,7 +114,7 @@ const withGiftFormActions = withActions(
 						if (giftCredits > 0 || giftCredits === 0) {
 							return updaters.setAllowance(giftCredits, monthlyAllowance, nextRenewalDate);
 						} else {
-							// TODO do something
+							return { invalidResponseFromApi: true }
 						}
 					}
 				}

diff --git a/components/x-gift-article/src/Message.jsx b/components/x-gift-article/src/Message.jsx
@@ -5,7 +5,7 @@ import styles from './GiftArticle.css';
 const messageClassName = styles.message;
 const boldTextClassName = styles.bold;
 
-export default ({ shareType, isGiftUrlCreated, isFreeArticle, giftCredits, monthlyAllowance, nextRenewalDateText, redemptionLimit }) => {
+export default ({ shareType, isGiftUrlCreated, isFreeArticle, giftCredits, monthlyAllowance, nextRenewalDateText, redemptionLimit, invalidResponseFromApi }) => {
 
 	if (isFreeArticle) {
 		return (
@@ -33,7 +33,7 @@ export default ({ shareType, isGiftUrlCreated, isFreeArticle, giftCredits, month
 			);
 		}
 
-		if (!giftCredits) {
+		if (invalidResponseFromApi) {
 			return (
 				<div className={ messageClassName }>
 					Unable to fetch gift credits. Please try again later

diff --git a/components/x-gift-article/src/UrlSection.jsx b/components/x-gift-article/src/UrlSection.jsx
@@ -23,6 +23,7 @@ export default ({
 	redemptionLimit,
 	showCopyButton,
 	nativeShare,
+	invalidResponseFromApi,
 	actions
 }) => {
 
@@ -50,6 +51,7 @@ export default ({
 				monthlyAllowance,
 				nextRenewalDateText,
 				redemptionLimit,
+				invalidResponseFromApi,
 			}} />
 
 			{ showUrlShareElements && <Buttons {...{