Skip to content

Commit

Permalink
Merge pull request #761 from Financial-Times/node-20
Browse files Browse the repository at this point in the history
Add support for Node.js 20
  • Loading branch information
joelcarr authored Jan 17, 2024
2 parents 2d87b16 + fe658ce commit dc7983c
Show file tree
Hide file tree
Showing 25 changed files with 95 additions and 83 deletions.
14 changes: 13 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ orbs:
executors:
node:
docker:
- image: cimg/node:18.16-browsers
- image: cimg/node:20.11-browsers
environment:
NODE_OPTIONS: "--openssl-legacy-provider"
node18_19:
docker:
- image: cimg/node:18.19-browsers
environment:
NODE_OPTIONS: "--openssl-legacy-provider"
node16_20:
Expand Down Expand Up @@ -154,6 +159,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- test:
requires:
Expand All @@ -163,6 +169,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- e2e-test:
requires:
Expand All @@ -172,6 +179,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- deploy:
filters:
Expand All @@ -193,6 +201,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- test:
requires:
Expand All @@ -202,6 +211,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20

build-test-publish-deploy:
Expand All @@ -214,6 +224,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- test:
filters:
Expand All @@ -225,6 +236,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- publish:
context: npm-publish-token
Expand Down
2 changes: 1 addition & 1 deletion components/x-article-save-button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@financial-times/x-engine": "file:../../packages/x-engine"
},
"engines": {
"node": "16.x || 18.x"
"node": "16.x || 18.x || 20.x"
},
"peerDependencies": {
"@financial-times/o-colors": "^6.4.2",
Expand Down
4 changes: 2 additions & 2 deletions components/x-follow-button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"classnames": "^2.2.6"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"volta": {
"extends": "../../package.json"
Expand Down
4 changes: 2 additions & 2 deletions components/x-gift-article/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"sass": "^1.49.0"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"volta": {
"extends": "../../package.json"
Expand Down
4 changes: 2 additions & 2 deletions components/x-increment/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"@financial-times/x-interaction": "file:../x-interaction"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"volta": {
"extends": "../../package.json"
Expand Down
4 changes: 2 additions & 2 deletions components/x-interaction/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/HEAD/components/x-interaction",
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions components/x-live-blog-post/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/HEAD/components/x-live-blog-post",
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions components/x-live-blog-wrapper/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/HEAD/components/x-live-blog-wrapper",
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions components/x-privacy-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/HEAD/components/x-privacy-manager",
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions components/x-styling-demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"classnames": "^2.2.6"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"volta": {
"extends": "../../package.json"
Expand Down
2 changes: 1 addition & 1 deletion components/x-teaser-list/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/master/components/x-teaser-list",
"engines": {
"node": "16.x || 18.x"
"node": "16.x || 18.x || 20.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions components/x-teaser-timeline/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/HEAD/components/x-teaser-timeline",
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions components/x-teaser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/HEAD/components/x-teaser",
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion components/x-topic-search/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"homepage": "https://github.com/Financial-Times/x-dash/tree/master/components/x-topic-search",
"engines": {
"node": "16.x || 18.x"
"node": "16.x || 18.x || 20.x"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"url": "https://github.com/Financial-Times/x-dash.git"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"publishConfig": {
"access": "public"
Expand Down
Loading

0 comments on commit dc7983c

Please sign in to comment.