Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-teaser-timeline #204

Closed
wants to merge 32 commits into from
Closed

x-teaser-timeline #204

wants to merge 32 commits into from

Conversation

dan-searle
Copy link
Contributor

@dan-searle dan-searle commented Oct 17, 2018 •
edited
Loading

x-dash version of myFT article timeline feed.

Checklist:

  • Take array of articles and split into groups by day, earlier, latest etc
  • Unit tests of article grouping
  • Render each article using x-teaser
  • styling of timeline in different viewports, heading styles etc
  • Documentation

@dan-searle dan-searle force-pushed the x-timeline-feed branch 5 times, most recently from e167b41 to 72b9ca5 Compare October 18, 2018 12:22
@dan-searle dan-searle mentioned this pull request Oct 19, 2018
Open
@i-like-robots i-like-robots added the component A new component in development label Oct 24, 2018
@dan-searle dan-searle force-pushed the x-timeline-feed branch 2 times, most recently from 6c3e17e to 2983144 Compare October 29, 2018 15:09
benbarnett
benbarnett reviewed Nov 2, 2018
View reviewed changes
Copy link
Contributor

@benbarnett benbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

components/x-timeline-feed/readme.md Outdated Show resolved Hide resolved
Dan Searle added 19 commits November 6, 2018 14:18
Beginnings of new x-timeline-feed component
e8e1584
Splitting of today's articles into latest/earlier.
91dfbb7
Allow today's date to set explicitly. Enables deterministic snapshot …
7fecc7a 
…testing.
Support styles.
ccbbd44
Set article group titles in one place. Pass localTodayDate around less.
9f351fd
Very basic unit tests.
b79ad1e
Use teaser data format for articles.
3b9c44f
Render articles as x-teasers
bb9a86d
Use Bower, add o-grid and o-typography as dependencies.
c47e1df
Use correct styles for article group heading, and only apply grid on …
14d3dfc 
…larger viewports.
Added articleActionsCreator prop for generating article action conten…
bff5563 
…t to render.
Unit test articleActionsCreator prop
d0c6dcf
Set default localTodayDate
62cf800
If no (or invalid) articles, then render nothing.
300936e
Basic documentation of props.
626ed66
Handle latestArticlesTime not being on localTodayDate.
2a40e27
Better docs
7c432b0
timezoneOffset prop default now uses runtime clock, to be consistent …
b8e9124 
…with localTodayDate default value. Also, use consistent way of converting full date/time to just date.
Don't create real Date objects when getting just date from an ISO dat…
1dda585 
…e-time, as it will cause the timezone to affect the results.
@dan-searle dan-searle changed the title x-timeline-feed x-teaser-timeline Nov 19, 2018
@dan-searle dan-searle mentioned this pull request Nov 20, 2018
Merged
@dan-searle
Copy link
Contributor Author

Closing as this now exists on a new branch: #223

@dan-searle dan-searle closed this Nov 20, 2018
@dan-searle dan-searle deleted the x-timeline-feed branch January 17, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaleslimghost apaleslimghost apaleslimghost left review comments

@benbarnett benbarnett benbarnett left review comments

@i-like-robots i-like-robots i-like-robots left review comments

Assignees
No one assigned
Labels
component A new component in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dan-searle @i-like-robots @benbarnett @apaleslimghost