Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide podcast app launchers on desktop #414

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/x-podcast-launchers/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,6 @@ Feature | Type | Required | Notes
`acastRSSHost` | String | Yes | e.g. 'https://acast.access.com'
`conceptId` | String | Yes |
`renderFollowButton` | Function | No | Optional render prop for the follow button
`isApp` | Boolean | No | Defaults to true. Currently only used to hide podcast app launchers on wide screen + desktop where the links do nothing because there is no app to launch.
apaleslimghost marked this conversation as resolved.
Show resolved Hide resolved

Additional props such as the `conceptName` may be required by x-follow-button. Documentation for these is available over in the component's readme.
53 changes: 26 additions & 27 deletions components/x-podcast-launchers/src/PodcastLaunchers.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,39 +48,38 @@ class PodcastLaunchers extends Component {

render() {
const { rssUrl } = this.state;
const { conceptId, conceptName, csrfToken, isFollowed, renderFollowButton } = this.props
const { conceptId, conceptName, csrfToken, isFollowed, renderFollowButton, isApp } = this.props
const followButton = typeof renderFollowButton === 'function' ? renderFollowButton : defaultFollowButtonRender;

return rssUrl && (
<div className={styles.container} data-trackable='podcast-launchers'>
<h2 className={styles.headingChooseApp}>Subscribe via your installed podcast app</h2>
<ul className={styles.podcastAppLinksWrapper}>
{generateAppLinks(rssUrl).map(({ name, url, trackingId }) => (
<li key={name}>
<a
href={url}
className={styles.podcastAppLink}
data-trackable={trackingId}>
{name}
</a>
</li>
))}

<li key='Rss Url' className={styles.rssUrlWrapper}>
<span className={rssUrlWrapperInner}>
<input value={rssUrl} type='text' readOnly/>
<button
className={styles.rssUrlCopyButton}
onClick={copyToClipboard}
data-url={rssUrl}
data-trackable='copy-rss'
type='button'>
Copy RSS
</button>
</span>
</li>
</ul>
<ul className={styles.podcastAppLinksWrapper}>
{generateAppLinks(rssUrl).map(({ name, url, trackingId }) => (
<li key={name} className={isApp ? "" : styles.hideAtWide}>
<a
href={url}
className={styles.podcastAppLink}
data-trackable={trackingId}>
{name}
</a>
</li>
))}

<li key='Rss Url' className={styles.rssUrlWrapper}>
<span className={rssUrlWrapperInner}>
<input value={rssUrl} type='text' readOnly/>
<button
className={styles.rssUrlCopyButton}
onClick={copyToClipboard}
data-url={rssUrl}
data-trackable='copy-rss'
type='button'>
Copy RSS
</button>
</span>
</li>
</ul>
<div className={noAppWrapperStyles}>
<h2 className={styles.headingNoApp}>Can’t see your podcast app?</h2>
<p className={styles.textNoApp}>Get updates for new episodes</p>
Expand Down
14 changes: 11 additions & 3 deletions components/x-podcast-launchers/src/PodcastLaunchers.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,18 @@ $o-buttons-is-silent: true;
margin: 0 0 24px;
}


/*
Hide podcast links at a wide screen width. We only do this when the running application
isn't the App so that on any native device you'll always be able to launch a podcast app
*/
.hidePodcastLinkAtWide {
@include oGridRespondTo(L) {
alicebartlett marked this conversation as resolved.
Show resolved Hide resolved
display: none;
}
}

.podcastAppLink {
@include oGridRespondTo(L) {
display: none;
}

@include oButtonsContent($opts: (
'type': 'primary',
Expand Down
3 changes: 2 additions & 1 deletion components/x-podcast-launchers/stories/example.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ exports.data = {
isFollowed: false,
csrfToken: 'token',
acastRSSHost: 'https://access.acast.com',
acastAccessToken: 'abc-123'
acastAccessToken: 'abc-123',
isApp: false,
};

// This reference is only required for hot module loading in development
Expand Down