Rename x-content-block to x-live-blog-post #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker-an
reviewed
Jun 19, 2020
| "module": "dist/ContentBlock.esm.js", | ||
| "browser": "dist/ContentBlock.es5.js", | ||
| "style": "dist/ContentBlock.css", | ||
| "main": "dist/LiveBlogPpost.cjs.js", |
There was a problem hiding this comment.
Small typo - there is an extra p here that needs to be removed
There was a problem hiding this comment.
Thanks Keran 👍
Should be fixed now.
ker-an
approved these changes
Jun 19, 2020
andygout
approved these changes
Jun 22, 2020
|
|
||
| This module displays a block of content with an id, title, body and timestamp. Main use case is the new version of live blogs, although we don't want to limit its usage to it. | ||
| This module displays a live blog post with an id, title, body and timestamp. |
There was a problem hiding this comment.
Pedantically, this sounds like the post displays the ID, which it doesn't. Although it does display the writer's name and social media links, which might be worth mentioning.
This is a side note and unrelated to the purpose of this PR, but I am raising it in case you want to do a small follow-up PR.
There was a problem hiding this comment.
Will do that. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
x-content-blocktox-live-blog-post.For
x-content-blockcomponent, please see this PR: #474