Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS to @financial-times/cp-customer-lifecycle #808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andygout
Copy link
Contributor

THIS PR IS TO BE MERGED ON: THU 02 JAN 2025

Description

This PR updates the CODEOWNERS file to reflect its new ownership.

Ticket

LIF-2: Admin for setting up Lifecycle team's resources


If this is your first x-dash pull request please familiarise yourself with the contribution guide before submitting.

If you're creating a component:

  • Add the Component label to this Pull Request
  • If this will be a long-lived PR, consider using smaller PRs targeting this branch for individual features, so your team can review them without involving x-dash maintainers
    • If you're using this workflow, create a Label and a Project for your component and ensure all small PRs are attached to them. Add the Project to the Components board
      • put a link to this Pull Request in the Project description
      • set the Project to Automated kanban with reviews, but remove the To Do column
    • If you're not using this workflow, add this Pull Request to the Components board.

  • Discuss features first
  • Update the documentation
  • Must be tested in FT.com and Apps before merge
  • No hacks, experiments or temporary workarounds
  • Reviewers are empowered to say no
  • Reference other issues
  • Update affected stories and snapshots
  • Follow the code style
  • Decide on a version (major, minor, or patch)

@andygout andygout requested a review from a team December 13, 2024 14:47
@andygout andygout requested a review from a team as a code owner December 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant