-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update x/bankplus for deprecation #1223
feat: update x/bankplus for deprecation #1223
Conversation
This reverts commit 630804b.
200a8dd
to
c1d6d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider implementing the migration on the app. You may try to implement it on simapp, and if it works, you can open the corresponding PR on Finschia/finschia.
bab18d6
to
7ee74a6
Compare
7ee74a6
to
503ac51
Compare
How about leaving deprecator in bankplus because it's used by finschia/finschia? And proto files shouldn't be removed. |
I'm thinking of closing this PR when another PR on finschia/finschia is ready. |
In my opinion, the repo that has better to have deprecator is finschia-sdk not finschia. If finschia, that makes it hard to follow history of bankplus and that makes proto files scattered. |
I agree. It seems better to keep bankplus logic here for history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CI testing bankplus? I suppose setting .github/workflow/test.yml is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
closes: #1212
lbm/bankplus/v1/bankplus.proto
has been deleted for deprecation.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml