feat!: add cosmwasmAPIGenerator to keeper
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to decide which API the methods of CosmwasmAPIGenerator will use
To be used when adding contract to inactive
and validateInterface in inactive contract
… it has been revised and deleted
loloicci
previously approved these changes
Apr 28, 2023
Kynea0b
previously approved these changes
May 1, 2023
dudong2
previously approved these changes
May 2, 2023
zemyblue
reviewed
May 3, 2023
remove unnecessary variables
NewWasmStore is needed as the default function of dynamic link, so it was moved to the wasm directory and changed so that it does not depend on wasmplus.
add description
zemyblue
approved these changes
May 8, 2023
loloicci
approved these changes
May 8, 2023
dudong2
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #38
In #36, x/wasm keeper was implemented as a dependency on x/wasmplus.
This meant that x/wasm could not run alone.
We added
cosmwasmAPIGeneratorto keeper in order to add dynamiclink functionality as a default function of x/wasm.This allows the methods of
cosmwasmAPIGeneratorto determine which API to use.In other words, it is now possible to change the behavior of the APIs within x/wasm and x/wasmplus.
cosmwasmAPIImplandcosmwasmAPIGeneratorImplcoexist and the logic is difficult to understand, so I will address this in issue #42Motivation and context
Because x/wasm was an implementation that depended on x/wasmplus,
we wanted to eliminate the dependency and change the contents of the API for x/wasm and x/wasmplus, respectively.
How has this been tested?
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml