Skip to content

Commit

Permalink
chore: address review feedback
Browse files Browse the repository at this point in the history
Throw an error if `firebase.json` is missing.
Print a neutral tracking log after processing GAC info
  • Loading branch information
minherz committed May 24, 2024
1 parent f68512d commit 1a36c4f
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,12 @@ async function run() {
if (existsSync("./firebase.json")) {
console.log("firebase.json file found. Continuing deploy.");
} else {
console.warn(
throw Error(
"firebase.json file not found. If your firebase.json file is not in the root of your repo, edit the entryPoint option of this GitHub action."
);
}
const gacFilename = await createGacFile(googleApplicationCredentials);
if (gacFilename !== googleApplicationCredentials) {
console.log(
"Created a temporary file with Google Application Credentials."
);
}
console.log("Google Application Credentials acquired.");
endGroup();

if (configuredChannelId === "live") {
Expand Down

0 comments on commit 1a36c4f

Please sign in to comment.