Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new disableComment input #357

Closed

Conversation

weilinzung
Copy link
Contributor

@weilinzung weilinzung commented Mar 26, 2024

Closes #356

  • To support the matrix strategy(multiple job runs), the best usage is to allow disabling auto-commenting to the pull request.
  • To allow disabling auto-commenting, this makes it less noisy, like 20+ matrix jobs could post 20+ comments

Copy link

google-cla bot commented Mar 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jhuleatt
Copy link
Collaborator

Hi @weilinzung, thank you! This needed a couple of changes, which I made in #371. I gave you co-author credit in that PR.

@jhuleatt jhuleatt closed this May 24, 2024
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Disable auto-commenting to PR for matrix jobs
2 participants