Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty channelId in test environment #404

Closed
wants to merge 6 commits into from

Conversation

wneel
Copy link

@wneel wneel commented Dec 27, 2024

Hi,

I figured out that the problem I was having in #403 was occurring because I was using act. But i then saw that there is no default case in the getChannelId function.

By adding this else statement, I'm ensuring that the channelId has a valid value before passing it to firebase-tools, otherwise errors will occur and it's hard to debug.

Now, here is the error I get when not using a channelId in a test environment:

{
  conclusion: 'failure',
  output: {
    title: 'Deploy preview failed',
    summary: 'Error: ChannelId is empty. No branch was found in the current context. Please provide a channelId for test environments.'
  }
}

And of course, according to the guidelines I've run:

npm run format:check

npm run build

npm run test

before opening the PR :)

I'm available for any changes or questions, I hope everything sounds good to you.

Copy link

google-cla bot commented Dec 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wneel wneel changed the title fix: https://github.com/FirebaseExtended/action-hosting-deploy/issues/403 fix: empty channelId in test environment Dec 27, 2024
@wneel wneel closed this Dec 27, 2024
@wneel wneel reopened this Dec 27, 2024
@wneel wneel closed this Dec 28, 2024
@wneel wneel reopened this Dec 28, 2024
@wneel wneel closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant