Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty channelId in test environment #405

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wneel
Copy link

@wneel wneel commented Dec 28, 2024

Hi,

I figured out that the problem I was having in #403 was occurring because I was using act. But i then saw that there is no default case in the getChannelId function.

By adding this else statement, I'm ensuring that the channelId has a valid value before passing it to firebase-tools, otherwise errors will occur and it's hard to debug.

Now, here is the error I get when not using a channelId in a test environment:

{
  conclusion: 'failure',
  output: {
    title: 'Deploy preview failed',
    summary: 'Error: ChannelId is empty. No branch was found in the current context. Please provide a channelId for test environments.'
  }
}

And of course, according to the guidelines I've run:

npm run format:check

npm run build

npm run test

before opening the PR :)

I'm available for any changes or questions, I hope everything sounds good to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant