Add isUnicode parameter to StringLiteralQueryType function #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
requested changes
Sep 25, 2024
src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/FbSqlGenerationHelper.cs
Outdated
Show resolved
Hide resolved
|
code changed, do I send a new PR? |
cincuranet
requested changes
Sep 26, 2024
| { | ||
| var length = MinimumStringQueryTypeLength(s); | ||
| EnsureStringLiteralQueryTypeLength(length); | ||
| return $"VARCHAR({length}) CHARACTER SET UTF8"; | ||
| var charset = isUnicode ? " CHARACTER SET UTF8" : ""; |
There was a problem hiding this comment.
Use string.Empty instead of "".
|
No need to send new PR. |
|
changed to string.empty |
cincuranet
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included the isUnicode parameter in the StringLiteralQueryType method so that it can be turned off if desired. tests performed on Firebird 4 and Firebird 5