Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FbZonedDateTime invalid cast #1194

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Fix FbZonedDateTime invalid cast #1194

merged 6 commits into from
Oct 17, 2024

Conversation

willibrandon
Copy link
Contributor

@willibrandon willibrandon commented Oct 8, 2024 •
edited
Loading

Fixes #1177

Implement IConvertible for FbZonedDateTime.

Adds an implementation for the IConvertible interface method ToDateTime. It returns the DateTime property of the FbZonedDateTime struct. This allows an instance of FbZonedDateTime to be converted to a DateTime object using the IConvertible interface.

@willibrandon willibrandon marked this pull request as ready for review October 8, 2024 06:49
@cincuranet
Copy link
Member

Really good. Just a few minor nits.

@cincuranet
Copy link
Member

BTW would you be interested in FbZonedTime -> TimeSpan implementation? If so, feel free to create another PR.

@cincuranet cincuranet merged commit c5b9fb9 into FirebirdSQL:master Oct 17, 2024
@willibrandon willibrandon deleted the fix-fbzoneddatetime-invalid-cast branch October 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FBZonedDateTime with legacy code
2 participants
@willibrandon @cincuranet