Postfix for #7917: Hang in a case of error when sweep thread is attac…

…hing to database; fixed CS case.
FirebirdSQL · Jan 5, 2024 · 1d1e3a5 · 1d1e3a5
1 parent e62ec5c
commit 1d1e3a5
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 12 deletions.
diff --git a/src/common/ThreadStart.h b/src/common/ThreadStart.h
@@ -112,7 +112,7 @@ inline ThreadId getThreadId()
 #define USE_FINI_SEM
 #endif
 
-template <typename TA>
+template <typename TA, void (*cleanup) (TA) = nullptr>
 class ThreadFinishSync
 {
 public:
@@ -203,6 +203,9 @@ class ThreadFinishSync
 			threadArg->exceptionHandler(ex, threadRoutine);
 		}
 #endif
+
+		if (cleanup)
+			cleanup(threadArg);
 		closing = true;
 	}
 };

diff --git a/src/jrd/tra.cpp b/src/jrd/tra.cpp
@@ -2718,11 +2718,6 @@ namespace {
 			: dbb(d)
 		{ }
 
-		void waitForStartup()
-		{
-			sem.enter();
-		}
-
 		static void runSweep(SweepParameter* par)
 		{
 			FbLocalStatus status;
@@ -2745,7 +2740,6 @@ namespace {
 				prov->setDbCryptCallback(&status, cryptCallback);
 				status.check();
 			}
-			par->sem.release();
 
 			AutoDispose<IXpbBuilder> dpb(UtilInterfacePtr()->getXpbBuilder(&status, IXpbBuilder::DPB, nullptr, 0));
 			status.check();
@@ -2769,14 +2763,26 @@ namespace {
 			ex.stuffException(&st);
 			if (st->getErrors()[1] != isc_att_shutdown)
 				iscLogException("Automatic sweep error", ex);
+
+			if (dbb)
+			{
+				dbb->clearSweepStarting();
+				SPTHR_DEBUG(fprintf(stderr, "called clearSweepStarting() dbb=%p par=%p\n", dbb, this));
+				dbb = nullptr;
+			}
+		}
+
+		static void cleanup(SweepParameter* par)
+		{
+			SPTHR_DEBUG(fprintf(stderr, "Cleanup dbb=%p par=%p\n", par->dbb, par));
+			delete par;
 		}
 
 	private:
-		Semaphore sem;
 		Database* dbb;
 	};
 
-	typedef ThreadFinishSync<SweepParameter*> SweepSync;
+	typedef ThreadFinishSync<SweepParameter*, SweepParameter::cleanup> SweepSync;
 	InitInstance<HalfStaticArray<SweepSync*, 16> > sweepThreads;
 	GlobalPtr<Mutex> swThrMutex;
 	bool sweepDown = false;
@@ -2848,10 +2854,9 @@ static void start_sweeper(thread_db* tdbb)
 		}
 
 		AutoPtr<SweepSync> sweepSync(FB_NEW SweepSync(*getDefaultMemoryPool(), SweepParameter::runSweep));
-		SweepParameter swPar(dbb);
-		sweepSync->run(&swPar);
+		SweepParameter* swPar = FB_NEW_POOL(*dbb->dbb_permanent) SweepParameter(dbb);
+		sweepSync->run(swPar);
 		started = true;
-		swPar.waitForStartup();
 		sweepThreads().add(sweepSync.release());
 	}
 	catch (const Exception&)