Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize String of name and goal bug #126 #127

Closed
wants to merge 0 commits into from

Conversation

gandhiv88
Copy link
Contributor

Added code to capitalize the name and goal as part of bug#126

@Cahllagerfeld
Copy link
Contributor

Hey @katalystkat, what do you think about that change?

See reference #126

My 2 cents:
I feel like if people hand in their name with lowercase its not on our app to capitalize it. The edge case I have in mind for this is, that if someone doesn't want to share their real name, and hands in their Github Username in the json for example. This might be intended to be lowercase (as its their username) Our app would capitalize it then, so there would not be an option to hand in a lowercase username.

@katalystkat
Copy link
Contributor

Hiya Cahl, let's capitalize it. Whether or not it visually shows up as capitalized or not, users can click on their usernames to be linked to their profile page anyways.

Copy link
Contributor

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Cahllagerfeld
Copy link
Contributor

Could you please resolve the merge conflict 👍 Other than that we are good to merge :)

@gandhiv88
Copy link
Contributor Author

gandhiv88 commented Aug 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants