Relax Julia compat version and solve_residuals!
method
#65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you working on this package! I have two issues that I would wish to be resolved here.
It seems strange that somehow the minimum Julia version was changed to v1.9 with Add Metal and CUDA as extensions #56. This seems unnecessary to me and also undesirable. With FixedEffectModels.jl now requiring FixedEffects.jl v2.3, all packages that directly or indirectly deals with fixed effects now requires Julia v1.9 to be paired with the latest versions of the two. This sounds way too much at least for the recent years.
A related issue is that the type restrictions for
solve_residuals!
seem to be too stringent. I would suggest having a fallback method as what I have did here that does not restrict the type ofxs
at all. If something wrong is passed to the method, then an error will be thrown anyway when the loop inside this fallback method iterate overxs
and call other methods ofsolve_residuals!
.Edit: I see that Metal.jl would cause some problem. But, the GPU part could be ignored if the Julia version is too old.