Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from dev before new version release #140

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

RyanDavies19
Copy link
Collaborator

Some minor bug fixes to be added before the MoorDyn release:

  1. Fixed typos across a number of areas, including references to the documentation
  2. Fixed an error that prevented outputs from being written when writelog flag was disabled
  3. Added a missing axial drag coefficient that was also added to MoorDynF discussed in MoorDyn updates and bug fixes OpenFAST/openfast#1727
  4. Made the internal Eigen the default flag for compiling
  5. Fixed the catenary solver and added support for anchors and fairleads reversed

@sanguinariojoe
Copy link
Collaborator

The tests are failing.

Can this maybe wait for 2.2.2 release? (2.2.2 is also a patch release, it should not take long until we do that)

@@ -6,7 +6,8 @@ build-backend = "setuptools.build_meta"
name = "moordyn"
version = "${MOORDYN_VERSION}"
authors = [
{ name="Jose Luis Cercos-Pita", email="[email protected]" },
{ name="Jose Luis Cercos-Pita", email="[email protected]" },
{ name="Matt Hall", email="[email protected]"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am totally OK with this, I mean, it is totally OK to me to share authorship.

However:

  • This is an open source project, so the license allows everyone to do almost whatever they want. Thus, adding authors have very little practical effect.
  • Usually the authors on a packaging are the ones who are maintaining it (no matter who is developing the packed software). The logic is that users can perfectly know who they should ask to in case of problems.

As I said, totally fine with me, but maybe you @RyanDavies19 and @mattEhall prefer to give it a second thought

@RyanDavies19
Copy link
Collaborator Author

@sanguinariojoe it can wait, as long as the patches come relatively soon. A few of the bug fixes are significant.

@sanguinariojoe
Copy link
Collaborator

@sanguinariojoe it can wait, as long as the patches come relatively soon. A few of the bug fixes are significant.

Otherwise you can fix the tests. I suppose it is not be a big deal actually

@sanguinariojoe sanguinariojoe mentioned this pull request Sep 28, 2023
@RyanDavies19
Copy link
Collaborator Author

@sanguinariojoe I updated all the tests to have a more accurate gravity value, the same as what is in MoorDynF and OpenFAST. All the tests pass so I am merging this into dev

@RyanDavies19 RyanDavies19 merged commit 55667f4 into FloatingArrayDesign:dev Sep 28, 2023
@RyanDavies19 RyanDavies19 deleted the ryan_dev branch October 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants