-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from dev before new version release #140
Conversation
The tests are failing. Can this maybe wait for 2.2.2 release? (2.2.2 is also a patch release, it should not take long until we do that) |
@@ -6,7 +6,8 @@ build-backend = "setuptools.build_meta" | |||
name = "moordyn" | |||
version = "${MOORDYN_VERSION}" | |||
authors = [ | |||
{ name="Jose Luis Cercos-Pita", email="[email protected]" }, | |||
{ name="Jose Luis Cercos-Pita", email="[email protected]" }, | |||
{ name="Matt Hall", email="[email protected]"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am totally OK with this, I mean, it is totally OK to me to share authorship.
However:
- This is an open source project, so the license allows everyone to do almost whatever they want. Thus, adding authors have very little practical effect.
- Usually the authors on a packaging are the ones who are maintaining it (no matter who is developing the packed software). The logic is that users can perfectly know who they should ask to in case of problems.
As I said, totally fine with me, but maybe you @RyanDavies19 and @mattEhall prefer to give it a second thought
@sanguinariojoe it can wait, as long as the patches come relatively soon. A few of the bug fixes are significant. |
Otherwise you can fix the tests. I suppose it is not be a big deal actually |
@sanguinariojoe I updated all the tests to have a more accurate gravity value, the same as what is in MoorDynF and OpenFAST. All the tests pass so I am merging this into dev |
Some minor bug fixes to be added before the MoorDyn release: