Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SharpVectors library #2655

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Remove unused SharpVectors library #2655

merged 3 commits into from
Jun 17, 2024

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Apr 18, 2024

This removes the unused SharpVectors library

Testing required

@jjw24 jjw24 marked this pull request as draft April 18, 2024 10:35
@taooceros
Copy link
Member

why is it draft? @jjw24

@JohnTheGr8
Copy link
Member

what about:

xmlns:svgc="http://sharpvectors.codeplex.com/svgc/"

@taooceros
Copy link
Member

what about:

xmlns:svgc="http://sharpvectors.codeplex.com/svgc/"

I think it is not used. Let's delete it. Maybe we add it to make support for svg sometimes but fail to provide a good resolution?

@taooceros taooceros marked this pull request as ready for review June 16, 2024 23:02
Copy link
Contributor

coderabbitai bot commented Jun 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent changes to the Flow.Launcher project involve the removal of references to the SharpVectors library in both the project file and the main window's XAML. This indicates a shift away from using specific components for handling SVG graphics and system-level functionality, potentially simplifying the project's dependencies and UI management.

Changes

Files Change Summary
Flow.Launcher/Flow.Launcher.csproj, Flow.Launcher/MainWindow.xaml Removed the package reference to SharpVectors and associated XML namespace declarations, indicating reduced reliance on SVG handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MainWindow
    participant System

    User->>MainWindow: Interacts with UI
    MainWindow->>System: Processes input
    System-->>MainWindow: Returns response
    MainWindow-->>User: Updates UI
Loading

Poem

🐇 In a world where vectors dance and play,
The rabbit hops with joy today!
No more SVGs to fret about,
Simpler paths, we cheer and shout!
With each leap, our code feels light,
Hooray for change, all feels just right! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gitstream-cm bot commented Jun 16, 2024

🥷 Code experts: onesounds

onesounds has most 👩‍💻 activity in the files.
onesounds has most 🧠 knowledge in the files.

See details

Flow.Launcher/Flow.Launcher.csproj

Activity based on git-commit:

onesounds
JUN 1 additions & 1 deletions
MAY 6 additions & 0 deletions
APR
MAR
FEB
JAN

Knowledge based on git-blame:
onesounds: 18%

Flow.Launcher/MainWindow.xaml

Activity based on git-commit:

onesounds
JUN 131 additions & 144 deletions
MAY 353 additions & 313 deletions
APR 138 additions & 57 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
onesounds: 95%

To learn more about /:\ gitStream - Visit our Docs

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented Jun 16, 2024

This PR is 0% new code.

Copy link

gitstream-cm bot commented Jun 16, 2024

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@taooceros taooceros merged commit b0ce62e into dev Jun 17, 2024
13 checks passed
@taooceros taooceros deleted the remove_sharpvectors branch June 17, 2024 17:04
@jjw24 jjw24 self-assigned this Jul 22, 2024
@jjw24 jjw24 added bug Something isn't working and removed 1 min review labels Jul 22, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants