Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Enabled" Column in Customize Action Keyword Tab #2918

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Aug 21, 2024

What's the PR

image

Test Cases

  • The item must be displayed appropriately.
  • It should be changed to suit the language.

@prlabeler prlabeler bot added the bug Something isn't working label Aug 21, 2024
@onesounds onesounds self-assigned this Aug 21, 2024
Copy link
Contributor

coderabbitai bot commented Aug 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent changes enhance the user interface of the Explorer settings in the Flow Launcher plugin. Key updates include correcting terminology for clarity, adding status indicators for enabled and disabled actions, and improving the XAML layout for better visual feedback. These adjustments aim to create a more intuitive and user-friendly experience, aligning with modern UI/UX standards.

Changes

Files Change Summary
Plugins/Flow.Launcher.Plugin.Explorer/... Corrected "Customise" to "Customize" in localization strings; added "Enabled" and "Disabled" entries.
Plugins/Flow.Launcher.Plugin.Explorer/... Added a new TextBlock for dynamic display of enabled/disabled status, with minor layout adjustments.

Assessment against linked issues

Objective Addressed Explanation
Better visual indicators for enabled/disabled actions (#[2821])
Improved layout for settings visibility (#[2821])
Clear indication of settings dialog (#[2821]) No changes made to indicate dialog accessibility.

Poem

🐇 In the meadow bright, where settings play,
A tweak here and there brings joy to the day.
With colors that dance and words that align,
Our plugin now sings, oh, how it does shine!
So hop with delight, as changes unfold,
A better Explorer, a sight to behold! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@onesounds onesounds added kind/ui related to UI, icons, themes, etc Explorer Plugin Issue or Enhancement Link to Explorer Plugin and removed bug Something isn't working labels Aug 21, 2024

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 merged commit 1911138 into Flow-Launcher:dev Aug 21, 2024
6 checks passed
@jjw24 jjw24 added bug Something isn't working and removed 1 min review labels Aug 21, 2024
@jjw24 jjw24 added this to the 1.19.1 milestone Aug 21, 2024
@jjw24 jjw24 removed the 1 min review label Sep 4, 2024
Copy link

gitstream-cm bot commented Sep 4, 2024

🥷 Code experts: Yusyuriv

onesounds, Yusyuriv have most 👩‍💻 activity in the files.
onesounds, jjw24 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml

Activity based on git-commit:

onesounds Yusyuriv
SEP
AUG 4 additions & 2 deletions
JUL
JUN 4 additions & 0 deletions 4 additions & 3 deletions
MAY 8 additions & 6 deletions 6 additions & 1 deletions
APR

Knowledge based on git-blame:
jjw24: 26%
onesounds: 16%

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml

Activity based on git-commit:

onesounds Yusyuriv
SEP
AUG 25 additions & 6 deletions
JUL
JUN 48 additions & 47 deletions 65 additions & 10 deletions
MAY 10 additions & 10 deletions 51 additions & 0 deletions
APR

Knowledge based on git-blame:
onesounds: 70%
jjw24: 1%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Explorer Plugin Issue or Enhancement Link to Explorer Plugin kind/ui related to UI, icons, themes, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Explorer settings ui/ux design to show enabled and disabled action hotkeys
2 participants