Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for setting result on top & keeping result order #3144

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Add options for setting result on top & keeping result order #3144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5e401f
Fix user result set max value issue
Jack251970 Dec 23, 2024
4ad967b
Add support for removing selected count from score
Jack251970 Dec 23, 2024
1c01fa4
update comment
jjw24 Dec 24, 2024
269e583
Add maximum score to the results for developers.
Jack251970 Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Flow.Launcher.Plugin/Result.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@ public ValueTask<bool> ExecuteAsync(ActionContext context)
/// </summary>
public PreviewInfo Preview { get; set; } = PreviewInfo.Default;

/// <summary>
/// Determines if the selected count should be added to the score
jjw24 marked this conversation as resolved.
Show resolved Hide resolved
/// </summary>
public bool AddSelectedCount { get; set; } = true;

/// <summary>
/// Info of the preview section of a <see cref="Result"/>
/// </summary>
Expand Down
6 changes: 4 additions & 2 deletions Flow.Launcher/ViewModel/MainViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,10 +1473,12 @@ public void UpdateResultView(ICollection<ResultsForUpdate> resultsForUpdates)
{
result.Score = int.MaxValue;
}
else
else if (result.Score != int.MaxValue)
Copy link
Member

@jjw24 jjw24 Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to note here, at some point I think it's best to provide an actual max value- standardise the scoring system so to not allow randomly assigning any score by plugins. #3022

Also this int max value is not documented anywhere so unless devs look into this Result class they probably won't know that they can do this.

Any how just thought I mention these, but they are out side the scope of this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjw24 Now I export the max score in the Result class so developers can see this maximum score.

{
var priorityScore = metaResults.Metadata.Priority * 150;
result.Score += _userSelectedRecord.GetSelectedCount(result) + priorityScore;
result.Score += result.AddSelectedCount ?
_userSelectedRecord.GetSelectedCount(result) + priorityScore :
priorityScore;
}
}
}
Expand Down
Loading