Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Composer script, fixes #1 #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hlubek
Copy link
Member

@hlubek hlubek commented Sep 28, 2022

Move custom wrapper script to a Composer script to have it in ´bin/prunner` (like expected for a Composer package) and errors on install.

Question: Calling bin/prunner outside of the project root doesn't work correctly with this approach. Does this matter for us?

@hlubek hlubek requested a review from skurfuerst September 28, 2022 09:06
@Benjamin-K
Copy link
Contributor

@hlubek We are running prunner from outside this package. As i understand your PR correctly, this will no longer be possible, right?

@hlubek
Copy link
Member Author

hlubek commented Feb 20, 2023

@Benjamin-K Hi, this is only about the script that is being managed by Composer and needed some special workarounds with composer.json until this PR. The script that will be installed in [project root]/bin/prunner needs to be called from the project root.

The Prunner process itself can still run outside of this package as before.

@christoph-daehne
Copy link
Contributor

This might relate to FEATURE: connect to existing Prunner system service. The Prunner binary is no longer installed via composer (opt-out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants