In QL charts, two queries are executed on Run button click (datalens-…

…tech#852)

* In QL charts, two queries are executed on Run button click

* temporarily fix yagr onRender issue

src/ui/units/ql/containers/PanePreview/PanePreview.tsx

@@ -7,7 +7,6 @@ import {connect} from 'react-redux';
 import {compose} from 'recompose';
 import {DatalensGlobalState, Utils} from 'ui';
 import {PlaceholderIllustration} from 'ui/components/PlaceholderIllustration/PlaceholderIllustration';
-import {getRandomCKId} from 'ui/libs/DatalensChartkit/helpers/helpers';
 
 import {ChartWrapper} from '../../../../components/Widgets/Chart/ChartWidgetWithProvider';
 import {ChartKitWrapperOnLoadProps} from '../../../../libs/DatalensChartkit/components/ChartKitBase/types';
@@ -107,11 +106,9 @@ class Preview extends React.PureComponent<PreviewProps, PreviewState> {
                 <ChartWrapper
                     usageType="chart"
                     id={entry?.entryId}
-                    key={getRandomCKId()}
                     config={previewConfig}
                     params={params}
                     onChartLoad={this.onChartLoad}
-                    onChartRender={this.onChartRender}
                     ref={this.chartKitRef}
                     disableChartLoader={true}
                     noVeil={true}
@@ -156,6 +153,10 @@ class Preview extends React.PureComponent<PreviewProps, PreviewState> {
             // Case when chart execution errored or has empty result
             this.props.setTablePreviewData({tablePreviewData: {}});
         }
+
+        // There is a problem with yagr widget - it does not call onRender callback every time it is rendered, only once
+        // Therefore, for now we are artificially calling callback to remove the loader
+        setTimeout(this.onChartRender);
     };
 
     onChartRender = () => {

tests/opensource-suites/ql/common/run.test.ts

@@ -0,0 +1,34 @@
+import {expect} from '@playwright/test';
+
+import QLPage from '../../../page-objects/ql/QLPage';
+import datalensTest from '../../../utils/playwright/globalTestDefinition';
+import {openTestPage} from '../../../utils';
+
+datalensTest.describe('QL', () => {
+    datalensTest(
+        'First and next click on Run button should trigger only one api/run request',
+        async ({page, config}) => {
+            await openTestPage(page, config.ql.urls.NewQLChartWithConnection);
+            const qlPage = new QLPage({page});
+            await qlPage.setScript(`select 1`);
+
+            let numberOfRequests = 0;
+            await page.on('request', (request) => {
+                if (request.url().includes('api/run')) {
+                    numberOfRequests += 1;
+                }
+            });
+
+            // Check first run
+            await qlPage.runScript();
+            await qlPage.chartkit.waitUntilLoaderExists();
+            expect(numberOfRequests).toEqual(1);
+
+            // Check second and other runs
+            numberOfRequests = 0;
+            await qlPage.runScript();
+            await qlPage.chartkit.waitUntilLoaderExists();
+            expect(numberOfRequests).toEqual(1);
+        },
+    );
+});