Added a Home Screen and the ability to add tasks #9

Rift3000 · 2021-04-06T04:31:52Z

No description provided.

hanskokx

I didn't try compiling and running this - I'm making the assumption that you wouldn't push it if it didn't compile.

hanskokx · 2021-04-06T18:40:55Z

lib/models/task.dart

+  final String title;
+  Icon taskIcon = Icon(Icons.alarm);
+
+  TaskList({this.title, this.taskIcon});


If title is empty, this will fail. Mark title as required.

hanskokx · 2021-04-06T18:42:11Z

lib/models/task_home_data.dart

+class TaskListHome extends ChangeNotifier {
+  List<TaskList> taskList = [
+    TaskList(title: "Rift's Corner", taskIcon: Icon(Icons.alarm)),
+    TaskList(title: "Han's Corner", taskIcon: Icon(Icons.run_circle)),


Han's => Hans'

hanskokx · 2021-04-06T18:43:00Z

lib/models/task_home_data.dart

+  }
+
+  void addTask(String myTaskTitle) {
+    final task = TaskList(title: myTaskTitle);


Will you add the taskIcon later?

I thinnk that is something that could be explored in the future. Allowing the user to select a task icon would be cool

hanskokx · 2021-04-06T18:44:00Z

lib/screens/add_task_screen.dart

                Navigator.pop(context);
              },
+              style: TextButton.styleFrom(backgroundColor: Colors.lightBlue),


Nit: Perhaps the color should be specified in a global theme? Then you can use Theme.of(context).xxxx

mmhhnnn you smart

hanskokx · 2021-04-06T18:48:13Z

lib/screens/home.dart

+                              style: TextStyle(
+                                  color: Colors.white,
+                                  fontSize:
+                                      MediaQuery.of(context).size.width / 20,


This seems like a dangerous calculation. Maybe set a minimum, and use a Wrap()?

Set it to a minimum? what do you mean?

Right now, the screen size always determines the font size. If someone happens to have a very small screen, the text could be size 2. Just do a simple if statement. If the resulting font size is smaller than ~10, use a font size of 10. Otherwise, make sure you are using a whole number.

hanskokx · 2021-04-06T18:48:46Z

lib/screens/home.dart

+      child: Text('Add A Task',
+          style: TextStyle(
+              color: Colors.white,
+              fontSize: MediaQuery.of(context).size.width / 20,


hanskokx · 2021-04-06T18:49:08Z

lib/screens/home.dart

+          cursorColor: Colors.white,
+          autocorrect: true,
+          onChanged: (newTitle) {
+            print(newTitle);


Don't forget to remove debugging statements

totally forgot

hanskokx · 2021-04-06T18:50:12Z

lib/screens/home.dart

+              elevation: 5.0,
+              padding: EdgeInsets.all(20.0)),
+          onPressed: () {
+            Provider.of<TaskListHome>(context, listen: false).addTask(title);


If this fails for some reason, we'll still pop. Might want to introduce some additional error handling, especially if this ends up pushing to a network resource (which may be unavailable)

Rift3000 · 2021-04-07T18:26:45Z

I addressed all the issues you highlighted and added two images to the Readme to show a little progress. Issues touched: Error handling, using ThemeData, debugging statements removed, etc. Currently don't see the need to add a wrap. We could possibly add it or review in the future.

hanskokx

Tiny changes, but otherwise looks good.

hanskokx · 2021-04-08T15:58:00Z

lib/screens/home.dart

-      ],
-    ),
-  );
+      backgroundColor: Colors.purple,


Maybe pull from the theme?

hanskokx · 2021-04-08T15:58:46Z

lib/screens/home.dart

+                    title = newTitle;
+                  },
+                  textAlign: TextAlign.center,
+                  style: TextStyle(color: Colors.black, fontSize: 20.0),


hanskokx · 2021-04-08T15:59:00Z

lib/screens/home.dart

+                  style: TextStyle(color: Colors.black, fontSize: 20.0),
+                  decoration: InputDecoration(
+                      filled: true,
+                      fillColor: Colors.white,


Theme?....you get the idea....

lol Really not seeing the point of changing every color to use theme. Enlighten me

Light mode vs Dark mode

Makes sense. Adding a dark mode later would be cool

Also, it keeps things consistent. If all the text should be the same color, using a shared variable saves time and effort when you want to change it.

Ok, I used Theme

hanskokx

So close! You can do it, Jason! 📣

hanskokx · 2021-04-09T00:44:51Z

lib/screens/home.dart

+          "Create",
+          style: TextStyle(color: Theme.of(context).canvasColor),
+        ),
+        backgroundColor: Colors.lightBlueAccent,


HOW did I miss these!!! LOL

lol..... takes one to know one.....

hanskokx · 2021-04-09T00:45:54Z

lib/screens/home.dart

+              clipBehavior: Clip.none,
+              children: <Widget>[
+                TextFormField(
+                  cursorColor: Colors.black,


hanskokx · 2021-04-09T00:46:45Z

lib/screens/home.dart

+                          ? IconButton(
+                              icon: Icon(
+                                Icons.error,
+                                color: Colors.red,


... I'll accept it

hanskokx · 2021-04-09T00:47:04Z

lib/screens/home.dart

+                          width: 270,
+                          height: 50,
+                          decoration: BoxDecoration(
+                              color: Colors.white,


hanskokx · 2021-04-09T00:47:35Z

lib/screens/home.dart

+            ),
+            ElevatedButton(
+              style: ElevatedButton.styleFrom(
+                  primary: Colors.lightBlue,


hanskokx · 2021-04-09T00:47:49Z

lib/screens/home.dart

+                }
+              },
+              child: Text('Add Task',
+                  style: TextStyle(color: Colors.white, fontSize: 20.0)),


Rift3000 · 2021-04-09T01:40:45Z

This time for sure! None escaped my sight

Rift3000 · 2021-04-09T02:09:30Z

Why not merge the pull request

hanskokx · 2021-04-09T16:04:08Z

Why not merge the pull request

Because I don't have permissions on this repo 🤷🏻‍♂️

Added a Home Screen and the ability to add tasks

0e20ba1

Rift3000 requested review from hanskokx and grayson-harrington April 6, 2021 04:31

hanskokx suggested changes Apr 6, 2021

View reviewed changes

Added basic error handling

3c464cd

hanskokx approved these changes Apr 8, 2021

View reviewed changes

Used Theme instead of hardcoding Colors

089f659

hanskokx suggested changes Apr 9, 2021

View reviewed changes

This time for sure! Used Theme for colors

f5edd46

hanskokx approved these changes Apr 9, 2021

View reviewed changes

hanskokx merged commit c74fcf6 into Flutter-Buddies:main Apr 9, 2021

hanskokx assigned Rift3000 Apr 9, 2021

This was linked to issues Apr 9, 2021

Create a Home Screen #2

Closed

Create Text notes #3

Open

Added a Home Screen and the ability to add tasks #9

Added a Home Screen and the ability to add tasks #9

Conversation

Rift3000 commented Apr 6, 2021

hanskokx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rift3000 commented Apr 7, 2021

hanskokx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hanskokx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rift3000 commented Apr 9, 2021

Rift3000 commented Apr 9, 2021

hanskokx commented Apr 9, 2021