fixed button overflow #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @slovnicki, please have a look at this PR when you have free time. |
|
Thanks for the PR @yash-1th! I'm on a vacation currently, but maybe @Zambrella can take a look sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fix to issue #66 . The text overflow on the button problem is fixed.
But, before fixing this issue I tried to run the app in debug mode in android phone which throwed an error: 'Execution failed for task ':audioplayers:compileDebugKotlin'. > Compilation error. See log for more'
Pastebin link: https://pastebin.com/vBHxSGif
Then a StackOverflow answer suggested to upgrade the kotlin to latest version: https://stackoverflow.com/a/66470639/10940882
Please let me know if this isn't the right approach to fix this error. Thanks.