Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade /programs, add desksaver #171

Closed
wants to merge 13 commits into from
Closed

Upgrade /programs, add desksaver #171

wants to merge 13 commits into from

Conversation

cwervo
Copy link
Collaborator

@cwervo cwervo commented Aug 15, 2024

The goal of this PR is two fold:

  • Upgrade the folkName.local/programs output to be more readable
  • Add a virtual-programs/desksaver.folk that displays RAM usage, basic metrics, and maybe a little animation to tell that the system is not completely frozen when there are no programs out on the table

This will address #130.

@cwervo cwervo added the enhancement New feature or request label Aug 15, 2024
@cwervo cwervo self-assigned this Aug 15, 2024
@osnr
Copy link
Collaborator

osnr commented Aug 15, 2024

We can probably factor this out of web.tcl and into a separate program (web/programs.folk) while we're at it right?

</nav>
<h1>Resource Usage</h1>
<div>
<!-- TODO: how to subs the real values into the html proc? -->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I'm missing something @osnr ... when I use subst here instead of html the page doesn't render at all, html doesn't fill in the $.*Usage variables though.

Screenshot 2024-08-15 at 11 52 25 PM

@cwervo cwervo requested a review from osnr October 25, 2024 20:36
@cwervo
Copy link
Collaborator Author

cwervo commented Oct 25, 2024

Re: splitting out web, I started that and want to finish that in a coming PR on this branch ac/docsv1 branch. This branch adds a desksaver watcher and is ready for review. Will merge Monday unless there are any requested changes. Remembered a few places where this is still unfinished, will finish this up next week.

@osnr
Copy link
Collaborator

osnr commented Nov 8, 2024

How is this looking right now? I'm a little skeptical of the value of this change now (is it clunky?), especially on the handheld system, given that we already have RAM checking and marching ants.

@cwervo
Copy link
Collaborator Author

cwervo commented Nov 11, 2024

Yeah, the RAM checking and marching ants on gadgets do make this a bit redundant. I'll close this PR and siphon out just the program page upgrades into a smaller PR and can merge that since it's a pure win.

@cwervo
Copy link
Collaborator Author

cwervo commented Nov 11, 2024

Closing, will siphon statement page upgrades into a smaller PR.

@cwervo cwervo closed this Nov 11, 2024
@cwervo cwervo deleted the ac/desksaver branch January 3, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants