Fix an issue where cli.FlagCount wasn't being parsed correctly (#116)

command_test.go

@@ -447,6 +447,18 @@ func TestHelp(t *testing.T) {
 			golden:  "with-named-arguments.txt",
 			wantErr: false,
 		},
+		{
+			name: "with verbosity count",
+			options: []cli.Option{
+				cli.OverrideArgs([]string{"--help"}),
+				cli.Arg("src", "The file to copy", ""),              // This one is required
+				cli.Arg("dest", "Destination to copy to", "./dest"), // This one is optional
+				cli.Flag(new(cli.FlagCount), "verbosity", 'v', 0, "Increase the verbosity level"),
+				cli.Run(func(cmd *cli.Command, args []string) error { return nil }),
+			},
+			golden:  "with-verbosity-count.txt",
+			wantErr: false,
+		},
 		{
 			name: "with full description",
 			options: []cli.Option{

internal/flag/set.go

@@ -206,7 +206,7 @@ func (s *Set) Usage() (string, error) {
 		tab.Row(
 			"  %s\t--%s\t%s\t%s\n",
 			colour.Bold(shorthand),
-			colour.Bold(flag.Name()),
+			colour.Bold(name),
 			flag.Type(),
 			flag.Usage(),
 		)

option.go

@@ -19,9 +19,13 @@ const NoShortHand = flag.NoShortHand
 // as e.g. a [time.Duration] is actually just an int64 underneath, likewise a [net.IP] is actually just []byte.
 type Flaggable flag.Flaggable
 
+// Note: this must be a type alias (FlagCount = flag.Count), not a newtype (FlagCount flag.Count)
+// otherwise parsing does not work correctly as the flag package does not know how to parse
+// a new type declared here.
+
 // FlagCount is a type used for a flag who's job is to increment a counter, e.g. a "verbosity"
 // flag may be passed "-vvv" which should increase the verbosity level to 3.
-type FlagCount flag.Count
+type FlagCount = flag.Count
 
 // Option is a functional option for configuring a [Command].
 type Option interface {

testdata/TestHelp/with-verbosity-count.txt

@@ -0,0 +1,12 @@
+A placeholder for something cool
+
+Usage: test [OPTIONS] SRC [DEST] 
+
+Arguments:
+  src   The file to copy
+  dest  Destination to copy to [default ./dest]
+
+Options:
+  -h  --help       bool   Show help for test
+  -v  --verbosity  count  Increase the verbosity level
+  -V  --version    bool   Show version info for test