No longer error if e.g cli.Version is passed an empty string (#111)

command_test.go

@@ -705,21 +705,6 @@ func TestOptionValidation(t *testing.T) {
 			options: []cli.Option{cli.OverrideArgs(nil)},
 			errMsg:  "cannot set Args to nil",
 		},
-		{
-			name:    "empty version",
-			options: []cli.Option{cli.Version("")},
-			errMsg:  "cannot set Version to an empty string",
-		},
-		{
-			name:    "empty commit",
-			options: []cli.Option{cli.Commit("")},
-			errMsg:  "cannot set Commit to an empty string",
-		},
-		{
-			name:    "empty build date",
-			options: []cli.Option{cli.BuildDate("")},
-			errMsg:  "cannot set BuildDate to an empty string",
-		},
 		{
 			name:    "nil VersionFunc",
 			options: []cli.Option{cli.VersionFunc(nil)},

option.go

@@ -267,9 +267,6 @@ func OverrideArgs(args []string) Option {
 //	cli.New("test", cli.Version("v1.2.3"))
 func Version(version string) Option {
 	f := func(cfg *config) error {
-		if version == "" {
-			return errors.New("cannot set Version to an empty string")
-		}
 		cfg.version = version
 		return nil
 	}
@@ -289,9 +286,6 @@ func Version(version string) Option {
 // [ldflags]: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications
 func Commit(commit string) Option {
 	f := func(cfg *config) error {
-		if commit == "" {
-			return errors.New("cannot set Commit to an empty string")
-		}
 		cfg.commit = commit
 		return nil
 	}
@@ -311,9 +305,6 @@ func Commit(commit string) Option {
 // [ldflags]: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications
 func BuildDate(date string) Option {
 	f := func(cfg *config) error {
-		if date == "" {
-			return errors.New("cannot set BuildDate to an empty string")
-		}
 		cfg.buildDate = date
 		return nil
 	}