Fix semibold font paths for open-sans.less #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1mo
added a commit
to chaos-jetzt/website_pelican
that referenced
this pull request
Sep 28, 2023
The Upstream repo changed the casing of the SemiBold from Semibold. Tho it was not changed in all locations[^1]. Going back to the comit prior to the change fixes the 404 on the font files. [^1]: Respective PRs have been open since 2018 and 2019: FontFaceKit/open-sans#36, FontFaceKit/open-sans#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font names and paths were recently changed from Semibold to SemiBold (and SemiboldItalic to SemiBoldItalic). However, open-sans.less was not updated to reflect the changes. This pull request fixes open-sans.less to reflect updated paths and font names.