-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podle commitment #191
Open
RajWorking
wants to merge
65
commits into
Fonta1n3:RAJ
Choose a base branch
from
RajWorking:podle-commitment
base: RAJ
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Podle commitment #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for Bitcoin Core 22.0, refactoring.
Committing fixes for release.
…d have been parsed as Int, this prevenetd the "onchain" balances from showing in the node manager section
fix: clightning internal onchain amounts in node manager view
…howed as 0 if there were no onchain funds in the internal onchain lightning wallet fix: disable send and sign button when broadcasting a signed c-lightning channel funding psbt
Fonta1n3
requested changes
Oct 12, 2021
FullyNoded/View Controllers/Home/Outgoing/UTXO's/UTXOViewController.swift
Outdated
Show resolved
Hide resolved
FullyNoded/View Controllers/Home/Outgoing/UTXO's/UTXOViewController.swift
Outdated
Show resolved
Hide resolved
…with a single key provided in a multisig descriptor caused a crash feat: support importing `ur:crypto-account` multisig descriptors
This will save any seeds as signers and create the public key descriptor to create a new wallet on your node.
…ith passport) TODO: handle adding a cosigner.
fix: Fonta1n3#160 and adds ability for localhost for c-lightning
fix: toggles in settings could have fired off other toggles
* Warning var/let * Bigint init from data * output format of dict
fix: better 2FA UX, set a timeout of 30 seconds fix: don't update local utxo labels with empty strings fix: don't lock the app on macos everytime it goes into background
…ners or single sig watch only fix: increase 2fa timeout to 6 minutes fix: add bip48 to descriptor parser fix: add 2fa timeout variable to all 2fa views fix: bad UX on active wallet 2fa feat: crypto-seed, crypto-output and crypto-account support for signers
feat: finish off wallet creation/recovery via signers
…instead of the signed raw tx to the transaction verifier fix: an issue when using a pruned node with a bitcoin core only wallet not showing input info in the transaction verifier
…y have not passed the signed raw tx to the tx verifier fix: show error message for testmempoolaccept command failing
fix: if no words still load table for wallet info
…utton fix: insanely annoying bug where outputs don't use an addresses array like they used to...
fix: better alert text on seigner detail view
feat: add icloud recovery for new signer items (xpubs) feat: show root xpub/ur:hdkey for casa app compatibility (not cosigner) fix: if 2fa failed signers never showed, now prompt until success
chore: prep for dmg
fix: bug where if signer words were deleted verifying one of our output addresses may have resulted in a never ending spinner
No longer include a dmg in the releases as it seems redundant. Users can just unzip the notarized app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twitter.com/fullynoded/status/1437941745002549251?s=21