Skip to content

Commit

Permalink
Merge pull request #374 from ForgeRock/SDKS-2751-security
Browse files Browse the repository at this point in the history
SDKS-2751 WoodStox + security vulnerability improvements
  • Loading branch information
spetrov authored Dec 11, 2023
2 parents 9803dbc + d84d644 commit 8ebf0ff
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 67 deletions.
30 changes: 27 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ buildscript {
classpath "com.adarshr:gradle-test-logger-plugin:2.0.0"
classpath 'com.google.gms:google-services:4.3.15'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.8.20"

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
Expand All @@ -36,15 +34,41 @@ buildscript {
plugins {
id('io.github.gradle-nexus.publish-plugin') version '1.1.0'
id('org.sonatype.gradle.plugins.scan') version '2.4.0'
id("org.jetbrains.dokka") version "1.9.10"
}

apply plugin: "org.jetbrains.dokka"

allprojects {
configurations.all {

resolutionStrategy {
// Due to vulnerability [CVE-2022-40152] from dokka project.
force 'com.fasterxml.jackson.module:jackson-module-kotlin:2.13.5'
force 'com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.13.5'
force 'com.fasterxml.jackson.core:jackson-databind:2.13.5'
// Junit test project
force 'junit:junit:4.13.2'
//Due to Vulnerability [CVE-2022-2390]: CWE-471 The product does not properly
// protect an assumed-immutable element from being modified by an attacker.
// on version < 18.0.1, this library is depended by most of the google libraries.
// and needs to be reviewed on upgrades
force 'com.google.android.gms:play-services-basement:18.1.0'
//Due to Vulnerability [CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types
//on version < 3.4.0, this library is depended by okhttp, when okhttp upgrade, this needs
//to be reviewed
force 'com.squareup.okio:okio:3.4.0'
//Due to this https://github.com/powermock/powermock/issues/1125, we have to keep using an
//older version of mockito until mockito release a fix
force 'org.mockito:mockito-core:3.12.4'
// this is for the mockwebserver
force 'org.bouncycastle:bcprov-jdk15on:1.68'
}
}
repositories {
google()
mavenCentral()
}

}

subprojects {
Expand Down
5 changes: 0 additions & 5 deletions forgerock-auth-ui/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ android {
apply from: '../config/kdoc.gradle'
apply from: '../config/publish.gradle'

configurations.all {
resolutionStrategy {
force 'com.google.android.gms:play-services-basement:18.1.0'
}
}

dependencies {

Expand Down
12 changes: 0 additions & 12 deletions forgerock-auth/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ apply plugin: 'maven-publish'
apply plugin: 'signing'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-parcelize'
apply plugin: 'org.jetbrains.dokka'

android {
namespace 'org.forgerock.android.auth'
Expand Down Expand Up @@ -83,17 +82,6 @@ apply from: '../config/publish.gradle'
* Dependencies
*
*/
configurations.all {
resolutionStrategy {
force 'com.google.android.gms:play-services-basement:18.1.0'
force 'junit:junit:4.13.2'
force 'org.bouncycastle:bcprov-jdk15on:1.68'
//Due to Vulnerability [CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types
//on version < 3.4.0, this library is depended by okhttp, when okhttp upgrade, this needs
//to be reviewed
force 'com.squareup.okio:okio:3.4.0'
}
}
dependencies {
api project(':forgerock-core')
implementation fileTree(dir: 'libs', include: ['*.jar'])
Expand Down
9 changes: 1 addition & 8 deletions forgerock-authenticator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ apply plugin: "com.adarshr.test-logger"
apply plugin: 'maven-publish'
apply plugin: 'signing'
apply plugin: 'kotlin-android'
// We cannot use kdoc for this project due to Lombak ,so need to add this dokka plugin here.
apply plugin: 'org.jetbrains.dokka'

android {
Expand Down Expand Up @@ -86,14 +87,6 @@ apply from: '../config/publish.gradle'
/**
* Dependencies
*/
configurations.all {
resolutionStrategy {
//Due to Vulnerability [CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types
//on version < 3.4.0, this library is depended by okhttp, when okhttp upgrade, this needs
//to be reviewed
force 'com.squareup.okio:okio:3.4.0'
}
}
dependencies {
api project(':forgerock-core')
implementation fileTree(dir: 'libs', include: ['*.jar'])
Expand Down
14 changes: 0 additions & 14 deletions forgerock-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ apply plugin: "com.adarshr.test-logger"
apply plugin: 'maven-publish'
apply plugin: 'signing'
apply plugin: 'kotlin-android'
apply plugin: 'org.jetbrains.dokka'

android {
namespace 'org.forgerock.android.core'
Expand Down Expand Up @@ -65,19 +64,6 @@ apply from: '../config/logger.gradle'
apply from: '../config/kdoc.gradle'
apply from: '../config/publish.gradle'

configurations.all {
//Due to this https://github.com/powermock/powermock/issues/1125, we have to keep using an
//older version of mockito until mockito release a fix
resolutionStrategy {
force 'org.mockito:mockito-core:3.12.4'
// this is for the mockwebserver
force 'org.bouncycastle:bcprov-jdk15on:1.68'
//Due to Vulnerability [CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types
//on version < 3.4.0, this library is depended by okhttp, when okhttp upgrade, this needs
//to be reviewed
force 'com.squareup.okio:okio:3.4.0'
}
}
/**
* Dependencies
*/
Expand Down
9 changes: 0 additions & 9 deletions samples/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,6 @@ repositories {
}
}

configurations.all {
resolutionStrategy {
force 'com.google.android.gms:play-services-basement:18.1.0'
//Due to Vulnerability [CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types
//on version < 3.4.0, this library is depended by okhttp, when okhttp upgrade, this needs
//to be reviewed
force 'com.squareup.okio:okio:3.4.0'
}
}
dependencies {

def composeBom = platform('androidx.compose:compose-bom:2022.10.00')
Expand Down
10 changes: 0 additions & 10 deletions samples/auth/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,6 @@ repositories {
}
}

configurations.all {
resolutionStrategy {
force 'com.google.android.gms:play-services-basement:18.1.0'
//Due to Vulnerability [CVE-2023-3635] CWE-681: Incorrect Conversion between Numeric Types
//on version < 3.4.0, this library is depended by okhttp, when okhttp upgrade, this needs
//to be reviewed
force 'com.squareup.okio:okio:3.4.0'
}
}

dependencies {

implementation project(':forgerock-auth')
Expand Down
6 changes: 0 additions & 6 deletions samples/kotlin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ android {
}
}

configurations.all {
resolutionStrategy {
force 'com.google.android.gms:play-services-basement:18.1.0'
}
}

dependencies {
implementation project(':forgerock-auth')
implementation 'net.openid:appauth:0.11.1'
Expand Down

0 comments on commit 8ebf0ff

Please sign in to comment.