PingProtect Implementation #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
5 times, most recently
from
c690693 to
c475b58
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
2 times, most recently
from
5176bb5 to
a1395d3
Compare
| @@ -93,7 +94,6 @@ dependencies { | |||
|
|
|||
| def coroutine_version = '1.7.2' | |||
| implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:$coroutine_version" | |||
| implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutine_version" | |||
There was a problem hiding this comment.
we dont need this anymore ..all the coroutines are part of org.jetbrains.kotlinx:kotlinx-coroutines-android:
| customCSSFile = projectDir.toString() + "/dokka/fr-backstage-styles.css" | ||
| customLogoFile = projectDir.toString() + "/dokka/logo-icon.svg" | ||
| customTemplatesFolder = file(projectDir.toString() + "/dokka/templates") | ||
| } | ||
| repositories { |
There was a problem hiding this comment.
moved all the repositories to settings.xml . @spetrov we may need to test the maven release to make sure this change works
| @@ -25,6 +25,5 @@ android.useAndroidX=true | |||
| GROUP=org.forgerock | |||
| VERSION=4.2.0 | |||
| VERSION_CODE=18 | |||
| android.defaults.buildfeatures.buildconfig=true | |||
There was a problem hiding this comment.
this is deprecated , so moved this buildconfig to build.gradle
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
3 times, most recently
from
0fc889f to
171e994
Compare
witrisna
previously approved these changes
Feb 5, 2024
| FRAuth.start(context, options) | ||
| current = options | ||
|
|
||
| CoroutineScope(Dispatchers.Default).launch { |
There was a problem hiding this comment.
May remove this from the sample, what about create another navigation menu to initialize the Protect SDK?
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
from
171e994 to
72500fe
Compare
spetrov
reviewed
Feb 5, 2024
| private val TAG = PingOneProtectInitCallback::class.java.simpleName | ||
|
|
||
| /** | ||
| * Callback to initialize the ping one protect |
There was a problem hiding this comment.
We should use consistent naming across the docs - i.e. PingOne Protect instead od "ping one protect"
rodrigoareis
requested changes
Feb 6, 2024
| @@ -12,124 +12,135 @@ import androidx.compose.runtime.getValue | |||
| import androidx.compose.runtime.mutableStateOf | |||
| import androidx.compose.runtime.setValue | |||
| import androidx.lifecycle.ViewModel | |||
| import kotlinx.coroutines.CoroutineScope | |||
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
from
72500fe to
899555d
Compare
|
comments addressed . |
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
2 times, most recently
from
39a48b2 to
0c18f8e
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-2900
branch
from
0c18f8e to
f0d7fb7
Compare
spetrov
approved these changes
Feb 7, 2024
witrisna
previously approved these changes
Feb 7, 2024
rodrigoareis
previously approved these changes
Feb 7, 2024
spetrov
requested changes
Feb 21, 2024
| /** | ||
| * Callback to initialize the ping one protect | ||
| */ | ||
| open class PingOneProtectInitCallback : AbstractCallback { |
There was a problem hiding this comment.
Shouldn't this class be called PingOneProtectInitializeCallback?
jeyanthanperiyasamy
dismissed stale reviews from rodrigoareis and witrisna
via
99352dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Please link jira ticket here
Description
Briefly describe the change and any information that would help speedup the review and testing.