Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3595 Remove Deprecated Sample Apps #464

Merged
merged 1 commit into from
Dec 11, 2024
Merged

SDKS-3595 Remove Deprecated Sample Apps #464

merged 1 commit into from
Dec 11, 2024

Conversation

witrisna
Copy link
Contributor

JIRA Ticket

SDKS-3593

Description

SDKS-3595 Remove Deprecated Sample Apps

@witrisna witrisna self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (8ca531f) to head (99da6de).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #464   +/-   ##
==========================================
  Coverage      64.41%   64.41%           
  Complexity      1666     1666           
==========================================
  Files            256      256           
  Lines           8641     8641           
  Branches         918      918           
==========================================
  Hits            5566     5566           
  Misses          2665     2665           
  Partials         410      410           
Flag Coverage Δ
unit-tests 64.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spetrov
spetrov previously approved these changes Nov 29, 2024
Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's confirm if we want to keep all the environments in the sample app...

rodrigoareis
rodrigoareis previously approved these changes Nov 29, 2024
Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@witrisna witrisna dismissed stale reviews from rodrigoareis and spetrov December 2, 2024 16:42

The merge-base changed after approval.

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@spetrov spetrov merged commit 9e3be1e into develop Dec 11, 2024
10 of 11 checks passed
@spetrov spetrov deleted the SDKS-3595 branch December 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants