Skip to content

Commit

Permalink
add note about linking pull requests to issues
Browse files Browse the repository at this point in the history
if pull request creators are considerate enough to follow this, it could
save the maintainers a lot of time in triaging issues to be closed after
they have already been merged into the icon set
  • Loading branch information
shinenelson committed Jun 25, 2021
1 parent 964d92e commit de02894
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ Adding a new icon is a couple steps process that will require your attention and
5. Once you are satisfied with your design and the preview of it. Add the icon name, unicode point and icon information at the bottom of the `src/icons/icons.yml` file. Look at other entries to see how it's done and to give it a proper classification.
6. Once all this is done, commit your changes and make a pull request.

Note : Please be considerate about maintainers' time and please
[link your pull requests] to the icon request issue if it exists. You
could use it within your commit message as well. This saves the
maintainers extra effort in having to keep track of and close completed
issues.

[link your pull requests]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

## Suggesting icon keyword addition/removal

Expand Down

0 comments on commit de02894

Please sign in to comment.