This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
[WIP] Resurrect victory-cli #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to suggest that we drop support for PNG and remove all librsvg dependencies. This would do a few things for us...
also, svgs are great! they are supported in all browser and scalable (they are vectors, dangit)! |
added 2 commits
June 4, 2020 11:29
kale-stew
commented
Jun 4, 2020
| @@ -24,8 +23,6 @@ program.option( | |||
| "'area', 'bar', 'line', 'scatter' or 'pie'", | |||
| "line" | |||
| ); | |||
| program.option("-f, --format [format]", "'png' or 'svg'", "png"); | |||
| program.option("-p, --print", "Prints chart to console (iTerm3 & .png format only!)"); | |||
There was a problem hiding this comment.
As this feature was dependent on a generated png, we no longer support printed imgs to iTerm either
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state, this package is not downloadable via any package manager (
npx,npm, andyarnall fail to download). This PR addresses the following issues to bring it back to a functional state:phantom