Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JANUS workflow #20

Closed
lsoucasse opened this issue Jun 3, 2024 · 0 comments · Fixed by #25
Closed

JANUS workflow #20

lsoucasse opened this issue Jun 3, 2024 · 0 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request

Comments

@lsoucasse
Copy link
Member

I think the JANUS module can benefit from a clearer workflow with new functions that encapsulate the main steps one can find in the SocRadConv script or the demo scripts (and the PROTEUS main script!).

It could be something like:
janus.setup_directories
janus.set_stellar_luminosity(stellar_spectral_file)
janus.run(config_file)
janus.write_atmosphere()
...

This is linked with the management of input data/parameters in both JANUS and PROTEUS (issue @FormingWorlds/PROTEUS#74)

@lsoucasse lsoucasse added the enhancement New feature or request label Jun 3, 2024
@lsoucasse lsoucasse moved this from TBD to In Progress in PROTEUS Development Roadmap Jun 7, 2024
@lsoucasse lsoucasse linked a pull request Jun 14, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in PROTEUS Development Roadmap Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants