Workflow #25
Merged
Workflow #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nichollsh
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Really nice to see JANUS using configuration files, rather than manually editing the source code. The SocRadConv.py example seems to work well, and the tests seem to pass with the correct behaviour.
Everything installs and runs okay on my machine.
We will need to update PROTEUS correspondingly with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work introduces a new atmosphere constructor that takes a toml config file as input to set up its parameters. Keywords entries are not set in stone and can be harmonized with AGNI and PROTEUS config files.