Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes and download stellar spectrum #34

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Minor fixes and download stellar spectrum #34

merged 5 commits into from
Jul 18, 2024

Conversation

nichollsh
Copy link
Contributor

@nichollsh nichollsh commented Jul 18, 2024

Now downloads stellar spectra from here: https://osf.io/8r2sw/, rather than using precomputed files in the spectral_files folder. This is important because the old files were outdated and not in a format consistent with what Mors produces. They were in the SOCRATES format with SI units and a specific header.

The spectra are now converted into the SOCRATES format by JANUS when they are inserted into the spectral file. This is done with PrepareStellarSpectrum in the same manner as in PROTEUS. The files produced by mors.SpectrumWrite can then be parsed appropriately.

As a result, the solar spectrum used by JANUS by default is slightly different to the previous one. The test reference values have been updated accordingly, but they only differ by a few decimal places.

@nichollsh nichollsh requested a review from lsoucasse July 18, 2024 13:54
Copy link
Member

@lsoucasse lsoucasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Things are starting to fall into place. It is much better to discriminate spectral files associated with the atmosphere and spectral files associated with the star.

I am wondering if all these stellar spectra should better fit into Mors but I think for now it is OK.

@lsoucasse lsoucasse merged commit 66f24f7 into master Jul 18, 2024
6 checks passed
@nichollsh
Copy link
Contributor Author

Thanks!

Yes, it would make more sense if they were downloaded by MORS instead of by JANUS. The spectra are downloaded to the shared FWL data folder regardless, but maybe the functions themselves should be moved.

@nichollsh nichollsh deleted the fixes branch July 18, 2024 14:47
lsoucasse added a commit that referenced this pull request Sep 24, 2024
Minor fixes and download stellar spectrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data for S2, SO2, and other gases
2 participants