Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share publications to corporations #42

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented Oct 18, 2017

Ref: #27

This is the simplest form of "social sharing": links to urls prepared to post to the users feed (facebook) and post to the users timeline (twitter).

We can add open graph parameters to the head section which will append an image & tittle to facebook's sharer. We will probably add the pertinent information when this other issue is worked on, so I won't work on it in this PR.

@AquiGorka AquiGorka requested a review from chadoh October 18, 2017 09:56
@AquiGorka AquiGorka changed the title Feature/social share Share publications to corporations Oct 18, 2017
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as a first pass. I see one problem with it, which we don't need to solve now:

Given the transient nature of how we're building the storage mechanism (no Filecoin or any easy way to let people secure their own data), the file will be picked up initially by Facebook/Twitter, but on later views if the data disappears from Thicket, then it won't show up on Facebook/Twitter, either.

I'm not sure if there's a way to get around that by uploading directly to Facebook/Twitter. Maybe we shouldn't even want to, but should instead prefer adding our own, more permanent data storage mechanism to Thicket.

@AquiGorka
Copy link
Contributor Author

Ok. Let's do some brainstorming then on how we think sharing should work/behave and take it from there. I'll merge this so that we have some base.

@AquiGorka AquiGorka merged commit c484781 into master Oct 18, 2017
@AquiGorka AquiGorka deleted the feature/social-share branch October 18, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants