use ip if no hostname is reported back #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaz
requested changes
Sep 16, 2021
| logrus.Error("missing reverse record for ", ip) | ||
| continue | ||
| logrus.Info("Missing reverse record for ", ip, ",using ip address instead.") | ||
| hostname = ip |
There was a problem hiding this comment.
Would you mind combining this with a command line flag perhaps -skip-reverse-dns or something. We have missing reverse records that we do not want to add to prometheus. The feature is to only add those who have reverse records.
Im sorry for this late reply but i've been on vaction.
There was a problem hiding this comment.
Sure,
i have created a new pull request introducing a new flag/switch: #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
for an environment not reporting back any hostnames, it may be usefull to use the ip address instead ignoring the host.