This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Add checkstyle #19
Merged
Add checkstyle #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I temporarily disabled the parts that validate Javadocs since we will handle that later in #8.
splitfeed
requested review from
magnusp,
indifferen7,
owtroid and
JonasHallFnx
splitfeed
commented
Dec 6, 2017
| --> | ||
| <module name="MethodParamPad" /> | ||
| <!-- | ||
| TODO We'll get to this later |
There was a problem hiding this comment.
I figured we could activate this for issue #8 later on, or this PR would be even more massive.
splitfeed
commented
Dec 6, 2017
| </module> | ||
| <!--<module name="JavadocParagraph"/>--> | ||
| <!-- TODO Javadocs will be resolved separately | ||
| <module name="JavadocType" /> |
JonasHallFnx
approved these changes
Dec 6, 2017
indifferen7
approved these changes
Dec 7, 2017
owtroid
approved these changes
Dec 7, 2017
splitfeed
commented
Dec 7, 2017
| * | ||
| * @author jonashall |
There was a problem hiding this comment.
Is there any reason to keep @author tags?
|
|
||
| import javax.ws.rs.*; |
There was a problem hiding this comment.
Perhaps we should allow asterisk imports after all, when the imports are more than like 5 or so? Or is there a real performance issue here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of whitespace changes here, so take a look here for instructions on how to ignore those: https://github.com/blog/967-github-secrets :)