Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fg 98 #793

Merged
merged 28 commits into from
Apr 4, 2024
Merged

Feature/fg 98 #793

merged 28 commits into from
Apr 4, 2024

Conversation

PTB03
Copy link
Contributor

@PTB03 PTB03 commented Mar 17, 2024 •
edited by Gissebass
Loading

Lagt til stylling på GridImageViewer, sjekk om det ser riktig ut:

  • Styllingen ser grei ut
  • Det er 4 bilder per rad, når nettsiden er i fullskjerm
  • Stylling funker for alle steder hvor GridImageViewer er brukt, search og event cards

Gissebass and others added 26 commits December 14, 2023 18:21
@Gissebass
fått enkel innlogging til å funke
b9c919b
@Gissebass
fått create user til å funke ish
90c6b46
@Gissebass
fixed login in header
003f7e0
@Gissebass
unstable finished
a6cf818
@Gissebass
change api endpoint fro 8080 to 8000
cf2760d
@Gissebass
kommentert ut litt kode som skal brukes senere.
3edd1fe
@Gissebass
updated browser-list-db because azure static check asked me to do so
cdd9e4f
@Gissebass
added linebreak to run azure static web apps i github
8f4f30a
@PTB03
lagt til createUser komponent
1cd21fc
@PTB03
Det funker plz!
37a58a2
@PTB03
Lagt til knapp til å komme seg tilbake til arkivsjef side
f1ff547
@PTB03
Lagt til input for fornavn og etternav,endret på styling også
7b44b33
@PTB03
begynt på side for endring av photgangbangers
ba6519e
@PTB03
FIX AZURE error lol
06aff8e
@PTB03
lagt til mulighet til å redigere info til en photogangbanger
32fc90c
@PTB03
Fikset og stylet redigeringSide, kan nå trykke på switch for om bruke…
d1b3abc 
…r er pang og eller aktiv
@PTB03
Slettet noen console logs
ec6e1c1
@PTB03
Fjerne enda none til console logs
5ae0fc3
@PTB03
Merge branch 'master' into feature/fg-94
be63b64
@PTB03
Dummy commit
83396c7
@PTB03
oppdatert Azure/msal/browser
5ce6bf9
@PTB03
Merge branch 'feature/fg-94' of https://github.com/Fotogjengen/hilfli…
3a8c91f 
…ng-frontend into feature/fg-94
@PTB03
Endret noen små feil
453fee8
@PTB03
slettet kommentar
d3bdee0
@PTB03
Endret på utsende på gridImageViewer, ser litt bedre ut nå
5d915ad
@PTB03
Gjorde rammene rundt bildene litt tynnere
e7f5213
@PTB03 PTB03 requested review from Gissebass and Jennytl March 17, 2024 12:02
@linear Linear
Copy link

linear bot commented Mar 17, 2024

FG-98 Fix styling for GridImageViewer

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-meadow-095743303-793.westeurope.2.azurestaticapps.net

Gissebass
Gissebass requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Gissebass Gissebass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix console logs and other todos before merging. Otherwise looks good.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-meadow-095743303-793.westeurope.2.azurestaticapps.net

@PTB03 PTB03 requested a review from Gissebass March 20, 2024 16:58
Gissebass
Gissebass approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Gissebass Gissebass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bra jobba Philip!
ᕙ(⇀‸↼‶)ᕗ

@PTB03 PTB03 merged commit d8a8a0b into master Apr 4, 2024
4 checks passed
@PTB03 PTB03 deleted the feature/fg-98 branch April 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gissebass Gissebass Gissebass approved these changes

@Jennytl Jennytl Awaiting requested review from Jennytl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PTB03 @Gissebass